Get core compiling with OCaml 5.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuragsoni
commented
Oct 6, 2022
Signed-off-by: Anurag Soni <[email protected]>
anuragsoni
force-pushed
the
conditional-compilation-for-500-4-14
branch
from
f934a5c to
23e609f
Compare
Signed-off-by: Anurag Soni <[email protected]>
anuragsoni
force-pushed
the
conditional-compilation-for-500-4-14
branch
from
cbdd604 to
2e350ea
Compare
|
This doesn't compile for me on either 4.14.0 or 5.0.0~alpha1. Any idea why? |
|
@tov what kind of error do you get? I just tried and everything compiled just fine for me. Are you sure you have all the janestreet libraries at their v0.15 version? |
|
I have it working now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested this extensively, but this diff got core 0.15 compiling for both ocaml 5, and ocaml 4.x. I wasn't sure how to best handle the api changes for Ephemeron so I've re-exported the stdlib module for now. This is a breaking change compared to 0.15, but this module wasn't available in prior core releases from what I can tell, and I couldn't find references to it at-least in the open-source libraries published within the janestreet GitHub org.